Merge pull request #1583 from tseaver/pylint-ignore_six_and_google_pr… · googleapis/google-cloud-python@95238be · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 441
• Pull requests 91
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 95238be

Browse filesBrowse the repository at this point in the historyBrowse files

tseaver

committed

Merge pull request #1583 from tseaver/pylint-ignore_six_and_google_protobf

Hide 'six' and 'google.protobuf' from pylint's borked import sniffing.

2 parents d38fd23 + dfced8a commit 95238be
Copy full SHA for 95238be

6 files changed

+9-6Lines changed: 9 additions & 6 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gcloud
  • _helpers.py
  • connection.py
  • credentials.py
  • storage
    • blob.py
  • streaming
    • http_wrapper.py
• scripts
  • pylintrc_default

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gcloud/_helpers.py‎

Copy file name to clipboardExpand all lines: gcloud/_helpers.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -25,7 +25,7 @@
25	25
26	26	from google.protobuf import timestamp_pb2
27	27	import six
28		- from six.moves.http_client import HTTPConnection # pylint: disable=F0401
	28	+ from six.moves.http_client import HTTPConnection
29	29
30	30	from gcloud.environment_vars import PROJECT
31	31

Collapse file

‎gcloud/connection.py‎

Copy file name to clipboardExpand all lines: gcloud/connection.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -17,7 +17,7 @@
17	17	import json
18	18	from pkg_resources import get_distribution
19	19	import six
20		- from six.moves.urllib.parse import urlencode # pylint: disable=F0401
	20	+ from six.moves.urllib.parse import urlencode
21	21
22	22	import httplib2
23	23

Collapse file

‎gcloud/credentials.py‎

Copy file name to clipboardExpand all lines: gcloud/credentials.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -17,7 +17,7 @@
17	17	import base64
18	18	import datetime
19	19	import six
20		- from six.moves.urllib.parse import urlencode # pylint: disable=F0401
	20	+ from six.moves.urllib.parse import urlencode
21	21
22	22	from oauth2client import client
23	23

Collapse file

‎gcloud/storage/blob.py‎

Copy file name to clipboardExpand all lines: gcloud/storage/blob.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -22,7 +22,7 @@
22	22	import time
23	23
24	24	import six
25		- from six.moves.urllib.parse import quote # pylint: disable=F0401
	25	+ from six.moves.urllib.parse import quote
26	26
27	27	from gcloud._helpers import _rfc3339_to_datetime
28	28	from gcloud.credentials import generate_signed_url

Collapse file

‎gcloud/streaming/http_wrapper.py‎

Copy file name to clipboardExpand all lines: gcloud/streaming/http_wrapper.py

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -12,8 +12,8 @@
12	12
13	13	import httplib2
14	14	import six
15		- from six.moves import http_client # pylint: disable=F0401
16		- from six.moves.urllib import parse # pylint: disable=F0401
	15	+ from six.moves import http_client
	16	+ from six.moves.urllib import parse
17	17
18	18	from gcloud.streaming.exceptions import BadStatusCodeError
19	19	from gcloud.streaming.exceptions import RequestError

Collapse file

‎scripts/pylintrc_default‎

Copy file name to clipboardExpand all lines: scripts/pylintrc_default

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -320,6 +320,9 @@ good-names = i, j, k, ex, Run, _,
320	320	# (useful for modules/projects where namespaces are manipulated during runtime
321	321	# and thus existing member attributes cannot be deduced by static analysis
322	322	# DEFAULT: ignored-modules=
	323	+ # RATIONALE: six aliases stuff for compatibility.
	324	+ # google.protobuf fixes up namespace package "late".
	325	+ ignored-modules = six, google.protobuf
323	326
324	327	# List of classes names for which member attributes should not be checked
325	328	# (useful for classes with attributes dynamically set).

0 commit comments

Comments

0 (0)