Add implicit connection/project support to Topic ctor. · googleapis/google-cloud-python@96b5925 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 97
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 96b5925

Browse filesBrowse the repository at this point in the historyBrowse files

tseaver

committed

Add implicit connection/project support to Topic ctor.

1 parent b48e262 commit 96b5925
Copy full SHA for 96b5925

2 files changed

+15-3Lines changed: 15 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gcloud/pubsub
  • test_topic.py
  • topic.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gcloud/pubsub/test_topic.py‎

Copy file name to clipboardExpand all lines: gcloud/pubsub/test_topic.py

+9-3Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -25,11 +25,17 @@ def _makeOne(self, *args, **kw):
25	25	return self._getTargetClass()(*args, **kw)
26	26
27	27	def test_ctor_wo_inferred_project_or_connection(self):
	28	+ from gcloud._testing import _monkey_defaults as _monkey_base_defaults
	29	+ from gcloud.pubsub._testing import _monkey_defaults
28	30	TOPIC_NAME = 'topic_name'
29		- topic = self._makeOne(TOPIC_NAME)
	31	+ PROJECT = 'PROJECT'
	32	+ conn = _Connection()
	33	+ with _monkey_base_defaults(project=PROJECT):
	34	+ with _monkey_defaults(connection=conn):
	35	+ topic = self._makeOne(TOPIC_NAME)
30	36	self.assertEqual(topic.name, TOPIC_NAME)
31		- self.assertEqual(topic.project, None)
32		- self.assertEqual(topic.connection, None)
	37	+ self.assertEqual(topic.project, PROJECT)
	38	+ self.assertTrue(topic.connection is conn)
33	39
34	40	def test_ctor_w_explicit_project_and_connection(self):
35	41	TOPIC_NAME = 'topic_name'

Collapse file

‎gcloud/pubsub/topic.py‎

Copy file name to clipboardExpand all lines: gcloud/pubsub/topic.py

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -16,7 +16,9 @@
16	16
17	17	import base64
18	18
	19	+ from gcloud._helpers import get_default_project
19	20	from gcloud.exceptions import NotFound
	21	+ from gcloud.pubsub._implicit_environ import get_default_connection
20	22
21	23
22	24	class Topic(object):
@@ -40,6 +42,10 @@ class Topic(object):
40	42	environment.
41	43	"""
42	44	def __init__(self, name, project=None, connection=None):
	45	+ if project is None:
	46	+ project = get_default_project()
	47	+ if connection is None:
	48	+ connection = get_default_connection()
43	49	self.name = name
44	50	self.project = project
45	51	self.connection = connection

0 commit comments

Comments

0 (0)