Make '_get_value_from_value_pb' rigorous about bytes vs. text. · googleapis/google-cloud-python@9809589 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 96
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 9809589

Browse filesBrowse the repository at this point in the historyBrowse files

tseaver

committed

Make '_get_value_from_value_pb' rigorous about bytes vs. text.

1 parent ad90b7b commit 9809589
Copy full SHA for 9809589

2 files changed

+6-3Lines changed: 6 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• gcloud/datastore
  • _helpers.py
  • test__helpers.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎gcloud/datastore/_helpers.py‎

Copy file name to clipboardExpand all lines: gcloud/datastore/_helpers.py

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -114,6 +114,9 @@ def _get_value_from_value_pb(value_pb):
114	114	elif value_pb.HasField('string_value'):
115	115	result = value_pb.string_value
116	116
	117	+ elif value_pb.HasField('blob_value'):
	118	+ result = value_pb.blob_value
	119	+
117	120	elif value_pb.HasField('entity_value'):
118	121	result = Entity.from_protobuf(value_pb.entity_value)
119	122

Collapse file

‎gcloud/datastore/test__helpers.py‎

Copy file name to clipboardExpand all lines: gcloud/datastore/test__helpers.py

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -156,9 +156,9 @@ def test_int(self):
156	156	pb = self._makePB('integer_value', 42)
157	157	self.assertEqual(self._callFUT(pb), 42)
158	158
159		- def test_native_str(self):
160		- pb = self._makePB('string_value', 'str')
161		- self.assertEqual(self._callFUT(pb), 'str')
	159	+ def test_bytes(self):
	160	+ pb = self._makePB('blob_value', b'str')
	161	+ self.assertEqual(self._callFUT(pb), b'str')
162	162
163	163	def test_unicode(self):
164	164	pb = self._makePB('string_value', u'str')

0 commit comments

Comments

0 (0)