fix(redis): deprecate resource name helper methods (via synth) (#9840) · googleapis/google-cloud-python@aa346f2 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 444
• Pull requests 99
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit aa346f2

Browse filesBrowse the repository at this point in the historyBrowse files

yoshi-automation

authored and

busunkim96

committed

fix(redis): deprecate resource name helper methods (via synth) (#9840)

1 parent ac88090 commit aa346f2
Copy full SHA for aa346f2

3 files changed

+29-9Lines changed: 29 additions & 9 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/google-cloud-redis
  • google/cloud
    • redis_v1beta1/gapic
      • cloud_redis_client.py
    • redis_v1/gapic
      • cloud_redis_client.py
  • synth.metadata

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/google-cloud-redis/google/cloud/redis_v1/gapic/cloud_redis_client.py‎

Copy file name to clipboardExpand all lines: packages/google-cloud-redis/google/cloud/redis_v1/gapic/cloud_redis_client.py

+12-2Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -100,7 +100,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
100	100
101	101	@classmethod
102	102	def instance_path(cls, project, location, instance):
103		- """Return a fully-qualified instance string."""
	103	+ """DEPRECATED. Return a fully-qualified instance string."""
	104	+ warnings.warn(
	105	+ "Resource name helper functions are deprecated.",
	106	+ PendingDeprecationWarning,
	107	+ stacklevel=1,
	108	+ )
104	109	return google.api_core.path_template.expand(
105	110	"projects/{project}/locations/{location}/instances/{instance}",
106	111	project=project,
@@ -110,7 +115,12 @@ def instance_path(cls, project, location, instance):
110	115
111	116	@classmethod
112	117	def location_path(cls, project, location):
113		- """Return a fully-qualified location string."""
	118	+ """DEPRECATED. Return a fully-qualified location string."""
	119	+ warnings.warn(
	120	+ "Resource name helper functions are deprecated.",
	121	+ PendingDeprecationWarning,
	122	+ stacklevel=1,
	123	+ )
114	124	return google.api_core.path_template.expand(
115	125	"projects/{project}/locations/{location}",
116	126	project=project,

Collapse file

‎packages/google-cloud-redis/google/cloud/redis_v1beta1/gapic/cloud_redis_client.py‎

Copy file name to clipboardExpand all lines: packages/google-cloud-redis/google/cloud/redis_v1beta1/gapic/cloud_redis_client.py

+12-2Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -101,7 +101,12 @@ def from_service_account_file(cls, filename, *args, **kwargs):
101	101
102	102	@classmethod
103	103	def instance_path(cls, project, location, instance):
104		- """Return a fully-qualified instance string."""
	104	+ """DEPRECATED. Return a fully-qualified instance string."""
	105	+ warnings.warn(
	106	+ "Resource name helper functions are deprecated.",
	107	+ PendingDeprecationWarning,
	108	+ stacklevel=1,
	109	+ )
105	110	return google.api_core.path_template.expand(
106	111	"projects/{project}/locations/{location}/instances/{instance}",
107	112	project=project,
@@ -111,7 +116,12 @@ def instance_path(cls, project, location, instance):
111	116
112	117	@classmethod
113	118	def location_path(cls, project, location):
114		- """Return a fully-qualified location string."""
	119	+ """DEPRECATED. Return a fully-qualified location string."""
	120	+ warnings.warn(
	121	+ "Resource name helper functions are deprecated.",
	122	+ PendingDeprecationWarning,
	123	+ stacklevel=1,
	124	+ )
115	125	return google.api_core.path_template.expand(
116	126	"projects/{project}/locations/{location}",
117	127	project=project,

Collapse file

‎packages/google-cloud-redis/synth.metadata‎

Copy file name to clipboardExpand all lines: packages/google-cloud-redis/synth.metadata

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -1,19 +1,19 @@
1	1	{
2		- "updateTime": "2019-11-12T13:36:07.423028Z",
	2	+ "updateTime": "2019-11-19T13:30:31.987393Z",
3	3	"sources": [
4	4	{
5	5	"generator": {
6	6	"name": "artman",
7		- "version": "0.41.1",
8		- "dockerImage": "googleapis/artman@sha256:545c758c76c3f779037aa259023ec3d1ef2d57d2c8cd00a222cb187d63ceac5e"
	7	+ "version": "0.42.1",
	8	+ "dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
9	9	}
10	10	},
11	11	{
12	12	"git": {
13	13	"name": "googleapis",
14	14	"remote": "https://github.com/googleapis/googleapis.git",
15		- "sha": "f69562be0608904932bdcfbc5ad8b9a22d9dceb8",
16		- "internalRef": "279774957"
	15	+ "sha": "d8dd7fe8d5304f7bd1c52207703d7f27d5328c5a",
	16	+ "internalRef": "281088257"
17	17	}
18	18	},
19	19	{

0 commit comments

Comments

0 (0)