FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use mock library in natural language tests. · googleapis/google-cloud-python@cb9b148 · GitHub

/ google-cloud-python Public

Commit cb9b148

Browse files
dhermes
committed
Use mock library in natural language tests.
1 parent 3de5bc0 commit cb9b148

7 files changed

Lines changed: 148 additions & 120 deletions

File tree

‎language/tox.ini‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ envlist =
55
[testing]
66
deps =
77
{toxinidir}/../core
8+
mock
89
pytest
910
covercmd =
1011
py.test --quiet \
@@ -25,6 +26,6 @@ basepython =
2526
commands =
2627
{[testing]covercmd}
2728
deps =
28-
{[testenv]deps}
29+
{[testing]deps}
2930
coverage
3031
pytest-cov

‎language/unit_tests/test_client.py‎

Lines changed: 34 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -17,28 +17,33 @@
1717

1818
class TestClient(unittest.TestCase):
1919

20-
def _getTargetClass(self):
20+
@staticmethod
21+
def _get_target_class():
2122
from google.cloud.language.client import Client
2223
return Client
2324

24-
def _makeOne(self, *args, **kw):
25-
return self._getTargetClass()(*args, **kw)
25+
def _make_one(self, *args, **kw):
26+
return self._get_target_class()(*args, **kw)
2627

2728
def test_ctor(self):
29+
import mock
2830
from google.cloud.language.connection import Connection
2931

30-
creds = _Credentials()
32+
creds = mock.Mock()
33+
creds.create_scoped_required.return_value = False
3134
http = object()
32-
client = self._makeOne(credentials=creds, http=http)
35+
client = self._make_one(credentials=creds, http=http)
3336
self.assertIsInstance(client.connection, Connection)
3437
self.assertIs(client.connection.credentials, creds)
3538
self.assertIs(client.connection.http, http)
3639

3740
def test_document_from_text_factory(self):
41+
import mock
3842
from google.cloud.language.document import Document
3943

40-
creds = _Credentials()
41-
client = self._makeOne(credentials=creds, http=object())
44+
creds = mock.Mock()
45+
creds.create_scoped_required.return_value = False
46+
client = self._make_one(credentials=creds, http=object())
4247

4348
content = 'abc'
4449
language = 'es'
@@ -52,17 +57,22 @@ def test_document_from_text_factory(self):
5257
self.assertEqual(document.language, language)
5358

5459
def test_document_from_text_factory_failure(self):
55-
creds = _Credentials()
56-
client = self._makeOne(credentials=creds, http=object())
60+
import mock
61+
62+
creds = mock.Mock()
63+
creds.create_scoped_required.return_value = False
64+
client = self._make_one(credentials=creds, http=object())
5765

5866
with self.assertRaises(TypeError):
5967
client.document_from_text('abc', doc_type='foo')
6068

6169
def test_document_from_html_factory(self):
70+
import mock
6271
from google.cloud.language.document import Document
6372

64-
creds = _Credentials()
65-
client = self._makeOne(credentials=creds, http=object())
73+
creds = mock.Mock()
74+
creds.create_scoped_required.return_value = False
75+
client = self._make_one(credentials=creds, http=object())
6676

6777
content = '<html>abc</html>'
6878
language = 'ja'
@@ -76,17 +86,22 @@ def test_document_from_html_factory(self):
7686
self.assertEqual(document.language, language)
7787

7888
def test_document_from_html_factory_failure(self):
79-
creds = _Credentials()
80-
client = self._makeOne(credentials=creds, http=object())
89+
import mock
90+
91+
creds = mock.Mock()
92+
creds.create_scoped_required.return_value = False
93+
client = self._make_one(credentials=creds, http=object())
8194

8295
with self.assertRaises(TypeError):
8396
client.document_from_html('abc', doc_type='foo')
8497

8598
def test_document_from_url_factory(self):
99+
import mock
86100
from google.cloud.language.document import Document
87101

88-
creds = _Credentials()
89-
client = self._makeOne(credentials=creds, http=object())
102+
creds = mock.Mock()
103+
creds.create_scoped_required.return_value = False
104+
client = self._make_one(credentials=creds, http=object())
90105

91106
gcs_url = 'gs://my-text-bucket/sentiment-me.txt'
92107
document = client.document_from_url(gcs_url)
@@ -97,11 +112,13 @@ def test_document_from_url_factory(self):
97112
self.assertEqual(document.doc_type, Document.PLAIN_TEXT)
98113

99114
def test_document_from_url_factory_explicit(self):
115+
import mock
100116
from google.cloud.language.document import Document
101117
from google.cloud.language.document import Encoding
102118

103-
creds = _Credentials()
104-
client = self._makeOne(credentials=creds, http=object())
119+
creds = mock.Mock()
120+
creds.create_scoped_required.return_value = False
121+
client = self._make_one(credentials=creds, http=object())
105122

106123
encoding = Encoding.UTF32
107124
gcs_url = 'gs://my-text-bucket/sentiment-me.txt'
@@ -113,16 +130,3 @@ def test_document_from_url_factory_explicit(self):
113130
self.assertEqual(document.gcs_url, gcs_url)
114131
self.assertEqual(document.doc_type, Document.HTML)
115132
self.assertEqual(document.encoding, encoding)
116-
117-
118-
class _Credentials(object):
119-
120-
_scopes = None
121-
122-
@staticmethod
123-
def create_scoped_required():
124-
return True
125-
126-
def create_scoped(self, scope):
127-
self._scopes = scope
128-
return self

‎language/unit_tests/test_connection.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717

1818
class TestConnection(unittest.TestCase):
1919

20-
def _getTargetClass(self):
20+
def _get_target_class(self):
2121
from google.cloud.language.connection import Connection
2222
return Connection
2323

24-
def _makeOne(self, *args, **kw):
25-
return self._getTargetClass()(*args, **kw)
24+
def _make_one(self, *args, **kw):
25+
return self._get_target_class()(*args, **kw)
2626

2727
def test_build_api_url(self):
28-
conn = self._makeOne()
28+
conn = self._make_one()
2929
uri = '/'.join([
3030
conn.API_BASE_URL,
3131
conn.API_VERSION,

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL