Fixing usage of public connection attribute in datastore system test. · googleapis/google-cloud-python@e06d1d3 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 97
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e06d1d3

Browse filesBrowse the repository at this point in the historyBrowse files

dhermes

committed

Fixing usage of public connection attribute in datastore system test.

Also fixing a merge issue with new datastore Iterator.

1 parent 38a0496 commit e06d1d3
Copy full SHA for e06d1d3

2 files changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• datastore/google/cloud/datastore
  • query.py
• system_tests
  • datastore.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎datastore/google/cloud/datastore/query.py‎

Copy file name to clipboardExpand all lines: datastore/google/cloud/datastore/query.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -492,7 +492,7 @@ def _next_page(self):
492	492	pb = self._build_protobuf()
493	493	transaction = self.client.current_transaction
494	494
495		- query_results = self.client.connection.run_query(
	495	+ query_results = self.client._connection.run_query(
496	496	query_pb=pb,
497	497	project=self._query.project,
498	498	namespace=self._query.namespace,

Collapse file

‎system_tests/datastore.py‎

Copy file name to clipboardExpand all lines: system_tests/datastore.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -45,7 +45,7 @@ def clone_client(client):
45	45	cloned_client = datastore.Client(project=client.project,
46	46	namespace=client.namespace,
47	47	http=object())
48		- cloned_client.connection = client.connection
	48	+ cloned_client._connection = client._connection
49	49	return cloned_client
50	50
51	51

0 commit comments

Comments

0 (0)