fix: Rename the 'seed' argument for setting an initial regional acces… · googleapis/google-cloud-python@e5c8cf9 · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 91
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit e5c8cf9

Browse filesBrowse the repository at this point in the historyBrowse files

macastelaz

authored

fix: Rename the 'seed' argument for setting an initial regional access boundary for clarity (#17186)

1 parent 49252da commit e5c8cf9
Copy full SHA for e5c8cf9

2 files changed

+8-8Lines changed: 8 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/google-auth/google/auth
  • _regional_access_boundary_utils.py
  • credentials.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/google-auth/google/auth/_regional_access_boundary_utils.py‎

Copy file name to clipboardExpand all lines: packages/google-auth/google/auth/_regional_access_boundary_utils.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -134,7 +134,7 @@ def enable_blocking_lookup(self):
134	134	self._use_blocking_regional_access_boundary_lookup = True
135	135
136	136	def set_initial_regional_access_boundary(self, encoded_locations=None, expiry=None):
137		- """Manually sets the regional access boundary to the client provided seed.
	137	+ """Manually sets the regional access boundary to the client provided initial values.
138	138
139	139	Args:
140	140	encoded_locations (Optional[str]): The encoded locations string.

Collapse file

‎packages/google-auth/google/auth/credentials.py‎

Copy file name to clipboardExpand all lines: packages/google-auth/google/auth/credentials.py

+7-7Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -371,11 +371,11 @@ def _copy_regional_access_boundary_manager(self, target):
371	371	new_manager._data = self._rab_manager._data
372	372	target._rab_manager = new_manager
373	373
374		- def _set_regional_access_boundary(self, seed):
375		- """Applies the regional_access_boundary provided via the seed on these
376		- credentials. This is intended for internal use only as invalid
377		- seeds would produce unexpected results until automatic recovery is supported.
378		- Currently this is used by the gcloud CLI and therefore changes to the
	374	+ def _set_regional_access_boundary(self, initial_boundary):
	375	+ """Applies the regional_access_boundary provided via the initial_boundary on these
	376	+ credentials. This is intended for internal use only as an invalid
	377	+ initial_boundary would produce unexpected results until automatic recovery
	378	+ is supported. Currently this is used by the gcloud CLI and therefore changes to the
379	379	contract MUST be backwards compatible (e.g. the method signature must be
380	380	unchanged and the credentials with the RAB set must be returned).
381	381
@@ -384,8 +384,8 @@ def _set_regional_access_boundary(self, seed):
384	384	google.auth.credentials.Credentials: The credentials instance.
385	385	"""
386	386	self._rab_manager.set_initial_regional_access_boundary(
387		- encoded_locations=seed.get("encodedLocations", None),
388		- expiry=seed.get("expiry", None),
	387	+ encoded_locations=initial_boundary.get("encodedLocations", None),
	388	+ expiry=initial_boundary.get("expiry", None),
389	389	)
390	390	return self
391	391

0 commit comments

Comments

0 (0)