fix(sqlalchemy-spanner): Drop support for Python 3.8 and 3.9 (#16913) · googleapis/google-cloud-python@f5b392e · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 442
• Pull requests 94
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f5b392e

Browse filesBrowse the repository at this point in the historyBrowse files

chalmerlowe

authored

fix(sqlalchemy-spanner): Drop support for Python 3.8 and 3.9 (#16913)

This PR updates `sqlalchemy-spanner` to establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below. ### Changes * Configuration: Updated `setup.py` and `noxfile.py` to require Python 3.10+ and remove references to Python 3.7, 3.8, and 3.9. * Cleanup: Removed dead code in `noxfile.py` that was skipping Python 3.7. ### Blocking This PR is blocked by PR #16910

1 parent 6698861 commit f5b392e
Copy full SHA for f5b392e

2 files changed

+5-7Lines changed: 5 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• packages/sqlalchemy-spanner
  • noxfile.py
  • setup.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎packages/sqlalchemy-spanner/noxfile.py‎

Copy file name to clipboardExpand all lines: packages/sqlalchemy-spanner/noxfile.py

+4-5Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -80,11 +80,10 @@ class = StreamHandler
80	80	BLACK_VERSION = "black==23.7.0"
81	81	ISORT_VERSION = "isort==5.11.0"
82	82	BLACK_PATHS = ["google", "tests", "noxfile.py", "setup.py", "samples"]
83		- UNIT_TEST_PYTHON_VERSIONS = ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
	83	+ UNIT_TEST_PYTHON_VERSIONS = ["3.10", "3.11", "3.12", "3.13", "3.14"]
84	84	ALL_PYTHON = list(UNIT_TEST_PYTHON_VERSIONS)
85		- ALL_PYTHON.extend(["3.7"])
86	85	SYSTEM_TEST_PYTHON_VERSIONS = ["3.12"]
87		- SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.8", "3.12", "3.14"]
	86	+ SYSTEM_COMPLIANCE_MIGRATION_TEST_PYTHON_VERSIONS = ["3.12", "3.14"]
88	87	DEFAULT_PYTHON_VERSION = "3.14"
89	88	DEFAULT_PYTHON_VERSION_FOR_SQLALCHEMY_20 = "3.14"
90	89
@@ -180,6 +179,8 @@ def compliance_test_14(session):
180	179	"--asyncio-mode=auto",
181	180	"tests/test_suite_14.py",
182	181	*session.posargs,
	182	+ # Silence SQLAlchemy 2.0 transition warnings for this 1.4 compatibility session.
	183	+ env={"SQLALCHEMY_SILENCE_UBER_WARNING": "1"},
183	184	)
184	185
185	186
@@ -318,8 +319,6 @@ def _migration_test(session):
318	319	@nox.parametrize("test_type", ["unit", "mockserver"])
319	320	def unit(session, test_type):
320	321	"""Run unit tests."""
321		- if session.python in ("3.7",):
322		- session.skip("Python 3.7 is no longer supported")
323	322
324	323	if (
325	324	test_type == "mockserver"

Collapse file

‎packages/sqlalchemy-spanner/setup.py‎

Copy file name to clipboardExpand all lines: packages/sqlalchemy-spanner/setup.py

+1-2Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -58,11 +58,10 @@
58	58	author="Google LLC",
59	59	author_email="googleapis-packages@google.com",
60	60	license="Apache 2.0",
	61	+ python_requires=">=3.10",
61	62	classifiers=[
62	63	"Intended Audience :: Developers",
63	64	"License :: OSI Approved :: Apache Software License",
64		- "Programming Language :: Python :: 3.8",
65		- "Programming Language :: Python :: 3.9",
66	65	"Programming Language :: Python :: 3.10",
67	66	"Programming Language :: Python :: 3.11",
68	67	"Programming Language :: Python :: 3.12",

0 commit comments

Comments

0 (0)