BQ: Pass selected_fields as a string to tabledata.list. (#4143) · googleapis/google-cloud-python@f7a52cb · GitHub

googleapis / google-cloud-python Public

• Notifications You must be signed in to change notification settings
• Fork 1.8k
• Star 5.4k

• Code
• Issues 444
• Pull requests 99
• Discussions
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit f7a52cb

Browse filesBrowse the repository at this point in the historyBrowse files

tswast

committed

BQ: Pass selected_fields as a string to tabledata.list. (#4143)

BigQuery was only returning the first column when passing in a list instead of a comma-separated string.

1 parent 9876ad6 commit f7a52cb
Copy full SHA for f7a52cb

2 files changed

+22-3Lines changed: 22 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• bigquery
  • google/cloud/bigquery
    • client.py
  • tests
    • system.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎bigquery/google/cloud/bigquery/client.py‎

Copy file name to clipboardExpand all lines: bigquery/google/cloud/bigquery/client.py

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -924,7 +924,8 @@ def list_rows(self, table, selected_fields=None, max_results=None,
924	924
925	925	params = {}
926	926	if selected_fields is not None:
927		- params['selectedFields'] = [f.name for f in selected_fields]
	927	+ params['selectedFields'] = ','.join(
	928	+ [f.name for f in selected_fields])
928	929	if start_index is not None:
929	930	params['startIndex'] = start_index
930	931

Collapse file

‎bigquery/tests/system.py‎

Copy file name to clipboardExpand all lines: bigquery/tests/system.py

+20-2Lines changed: 20 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -312,8 +312,9 @@ def test_update_table_schema(self):
312	312	self.assertEqual(found.mode, expected.mode)
313	313
314	314	@staticmethod
315		- def _fetch_single_page(table):
316		- iterator = Config.CLIENT.list_rows(table)
	315	+ def _fetch_single_page(table, selected_fields=None):
	316	+ iterator = Config.CLIENT.list_rows(
	317	+ table, selected_fields=selected_fields)
317	318	page = six.next(iterator.pages)
318	319	return list(page)
319	320
@@ -1236,6 +1237,23 @@ def test_dump_table_w_public_data(self):
1236	1237	table = Config.CLIENT.get_table(table_ref)
1237	1238	self._fetch_single_page(table)
1238	1239
	1240	+ def test_dump_table_w_public_data_selected_fields(self):
	1241	+ PUBLIC = 'bigquery-public-data'
	1242	+ DATASET_ID = 'samples'
	1243	+ TABLE_NAME = 'natality'
	1244	+ selected_fields = [
	1245	+ bigquery.SchemaField('year', 'INTEGER', mode='NULLABLE'),
	1246	+ bigquery.SchemaField('month', 'INTEGER', mode='NULLABLE'),
	1247	+ bigquery.SchemaField('day', 'INTEGER', mode='NULLABLE'),
	1248	+ ]
	1249	+ table_ref = DatasetReference(PUBLIC, DATASET_ID).table(TABLE_NAME)
	1250	+
	1251	+ rows = self._fetch_single_page(
	1252	+ table_ref, selected_fields=selected_fields)
	1253	+
	1254	+ self.assertGreater(len(rows), 0)
	1255	+ self.assertEqual(len(rows[0]), 3)
	1256	+
1239	1257	def test_large_query_w_public_data(self):
1240	1258	PUBLIC = 'bigquery-public-data'
1241	1259	DATASET_ID = 'samples'

0 commit comments

Comments

0 (0)