FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Cleanup] Don't use django fork in build script · Issue #15951 · googleapis/google-cloud-python · GitHub

[Cleanup] Don't use django fork in build script #15951

Description

CI tests use a fork of django: https://github.com/c24t/django/tree/spanner/stable/2.2.x. This fork includes many changes required to run the django tests with spanner. See the full list here.

Decide how to handle this fork long term, and ensure that it's up to date with the most-recently released version of django (for each version we support). Check that we still need these patches after fast-forwarding the underlying django branch in googleapis/python-spanner-django#598.

Was previously:

The CI build script is using @timgraham's fork of django:

https://github.com/googleapis/python-spanner-django/blob/94ba284118c6cb02fccc9d40bb6c1e52d3a532a0/.kokoro/build.sh#L60

It looks like this was added in googleapis/python-spanner-django@27222a3, but I can't tell why we needed to use this instead of django/django. Maybe because @timgraham merged a fix on his fork before it it was available on main?

In any case we should remove this now if we can. Related to the test cleanup work in googleapis/python-spanner-django#471.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: spannerIssues related to the Spanner API.priority: p2Moderately-important priority. Fix may not be included in next release.type: cleanupAn internal cleanup or hygiene concern.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL