feat(api-core): add tracer_provider to ClientOptions for OTel support - #18139
Draft
chalmerlowe wants to merge 4 commits into
Draft
feat(api-core): add tracer_provider to ClientOptions for OTel support#18139chalmerlowe wants to merge 4 commits into
chalmerlowe wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry helper functions to resolve and instantiate gRPC client interceptors, and adds a tracer_provider attribute to ClientOptions along with corresponding unit tests. The review feedback suggests simplifying the attribute access on client_options by avoiding defensive getattr calls since the attribute is guaranteed to be initialized on the class.
Sorry, something went wrong.
Comment thread
packages/google-api-core/google/api_core/_otel_helpers.py
Outdated
chalmerlowe
commented
Aug 18, 2026
Comment thread
packages/google-api-core/tests/unit/test_otel_helpers.py
Outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
Assignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP