FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

for testing purposes by parthea · Pull Request #18170 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

for testing purposes - #18170

Draft
parthea wants to merge 2 commits into
mainfrom
chore-update-librarian-2026-08-19
ConversationCommits (2)ChecksFiles changed
Draft

for testing purposes#18170
parthea wants to merge 2 commits into
mainfrom
chore-update-librarian-2026-08-19

Conversation

parthea commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

gemini-code-assist Bot reviewed Aug 19, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request updates the minimum supported version of google-api-core to 2.28.0 across various post-processing configurations and constraints. It introduces a compatibility module _compat.py in google-ads-admanager to handle older versions of google-api-core gracefully, and refactors all REST transports to utilize a centralized transcode_request helper, significantly reducing boilerplate code in the generated transport classes. Additionally, manual Python and dependency version checks in __init__.py have been replaced with direct calls to api_core. There are no review comments to assess, so I have no further feedback to provide.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL