| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sorry, something went wrong.
|
Memo:
|
Sorry, something went wrong.
|
@cHengstler Can you fix the lint failure? [INFO] --- fmt-maven-plugin:2.9:check (default-cli) @ google-http-client --- [INFO] Processed 100 files (1 non-complying). [INFO] Processed 200 files (1 non-complying). [INFO] Processed 216 files (2 non-complying). Error: Found 2 non-complying files, failing build Error: To fix formatting errors, run "mvn com.coveo:fmt-maven-plugin:format" Error: Non complying file: /home/runner/work/google-http-java-client/google-http-java-client/google-http-client/src/main/java/com/google/api/client/util/escape/PercentEscaper.java Error: Non complying file: /home/runner/work/google-http-java-client/google-http-java-client/google-http-client/src/test/java/com/google/api/client/http/UriTemplateTest.java |
Sorry, something went wrong.
|
Hi @suztomo, thanks for reviewing, linting issues should be solved now. |
Sorry, something went wrong.
| assertEquals( | ||
| "Reserved expansion must not escape chars from unreserved set according to rfc6570#section-3.2.3", | ||
| unReservedSet, | ||
| UriTemplate.expand("{+var}", requestMap, false)); |
There was a problem hiding this comment.
Memo: Python's uritemplate agrees:
>>> a="-._~"; a == URITemplate("{+var}").expand(var=a)
True
>>> a=":/?#[]@!$&'()*+,;="; a == URITemplate("{+var}").expand(var=a)
True
Sorry, something went wrong.
|
ci / lint passed. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
When using UriTemplate.expand with a reserved expansion "{+var}", a set of allowed characters must not be encoded. According to section of 3.2.3 Reserved Expansion: {+var}, unreserved and reserved character should not be escaped.
This fix adds the missing characters #[] that must not be percent encoded when using reserved expansion.
Fixes #1838