FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: null field mode inconsistency by obada-ab · Pull Request #2863 · googleapis/java-bigquery · GitHub

This repository was archived by the owner on Mar 23, 2026. It is now read-only.
/ java-bigquery Public archive

fix: null field mode inconsistency - #2863

Merged
PhongChuong merged 3 commits into
mainfrom
null-field-mode
Jul 12, 2024
ConversationCommits (3)ChecksFiles changed
Merged

fix: null field mode inconsistency#2863
PhongChuong merged 3 commits into
mainfrom
null-field-mode

Conversation

obada-ab commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2730 ☕️

obada-ab requested review from a team and chalmerlowe September 5, 2023 11:44
product-auto-label Bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Sep 5, 2023
obada-ab added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 25, 2023
Merge branch 'main' into null-field-mode
1626d93 
# Conflicts:
#	google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
PhongChuong removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 12, 2024
PhongChuong merged commit b9e96e3 into main Jul 12, 2024
PhongChuong deleted the null-field-mode branch July 12, 2024 16:36
release-please Bot mentioned this pull request Jul 12, 2024
Merged
This was referenced Jul 30, 2024
Closed
Closed
Closed
lqiu96 pushed a commit that referenced this pull request Aug 28, 2024
fix: null field mode inconsistency (#2863)
1ab53a8 
* fix: null field mode inconsistency

* chore: update null field mode test name

---------

Co-authored-by: PhongChuong <phong.hoa.chuong@gmail.com>
release-please Bot mentioned this pull request Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

chalmerlowe Awaiting requested review from chalmerlowe
1 more reviewer
PhongChuong PhongChuong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The Field mode normalization for null values is incorrect and sets it as an empty String.

2 participants

Back | FazBrowse Home | New Git URL