FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add MetadataCacheMode to ExternalTableDefinition by PhongChuong · Pull Request #3351 · googleapis/java-bigquery · GitHub

This repository was archived by the owner on Mar 23, 2026. It is now read-only.
/ java-bigquery Public archive

feat: add MetadataCacheMode to ExternalTableDefinition - #3351

Merged
PhongChuong merged 3 commits into
mainfrom
b346589409
Jun 19, 2024
ConversationCommits (3)ChecksFiles changed
Merged

feat: add MetadataCacheMode to ExternalTableDefinition#3351
PhongChuong merged 3 commits into
mainfrom
b346589409

Conversation

PhongChuong commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3350 ☕️

PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2024
PhongChuong marked this pull request as ready for review June 14, 2024 16:52
PhongChuong requested review from a team, alvarowolfx and shollyman June 14, 2024 16:52
product-auto-label Bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jun 15, 2024
product-auto-label Bot added the size: m Pull request size is medium. label Jun 18, 2024
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 18, 2024
gcf-owl-bot Bot requested a review from a team June 18, 2024 19:38
PhongChuong commented Jun 18, 2024
View reviewed changes

PhongChuong left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the review. Updated. PTAL.

Comment thread google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ExternalTableDefinition.java
PhongChuong merged commit 2814dc4 into main Jun 19, 2024
PhongChuong deleted the b346589409 branch June 19, 2024 13:30
release-please Bot mentioned this pull request Jun 22, 2024
Merged
This was referenced Jul 2, 2024
Closed
Closed
Closed
release-please Bot mentioned this pull request Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

alvarowolfx Awaiting requested review from alvarowolfx
1 more reviewer
shollyman shollyman approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support MetadataCacheMode in ExternalTableDefinition

3 participants

Back | FazBrowse Home | New Git URL