This repository was archived by the owner on Mar 23, 2026. It is now read-only.
feat: add additional parameters to CsvOptions and ParquetOptions - #3370
Merged
PhongChuong merged 5 commits intoJun 28, 2024
Merged
feat: add additional parameters to CsvOptions and ParquetOptions#3370PhongChuong merged 5 commits into
PhongChuong merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
shollyman
approved these changes
Jun 27, 2024
shollyman
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Generally looks good, a couple of minor questions.
Sorry, something went wrong.
Comment thread
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/CsvOptions.java
Outdated
…into ExternalTableDefinitionOptions
PhongChuong
commented
Jun 27, 2024
PhongChuong
left a comment
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. Updated to address the comments. PTAL.
Sorry, something went wrong.
Comment thread
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/CsvOptions.java
Outdated
This was referenced Jul 30, 2024
lqiu96
pushed a commit
that referenced
this pull request
Aug 28, 2024
* feat: add additional parameters to CsvOptions and ParquetOptions * fix lint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Addressed review comments --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #3369 ☕️