FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(test): Update schema for broken ConnImplBenchmark test by o-shevchenko · Pull Request #3574 · googleapis/java-bigquery · GitHub

This repository was archived by the owner on Mar 23, 2026. It is now read-only.
/ java-bigquery Public archive

fix(test): Update schema for broken ConnImplBenchmark test - #3574

Merged
PhongChuong merged 2 commits into
googleapis:mainfrom
o-shevchenko:benchmark
Dec 3, 2024
ConversationCommits (2)ChecksFiles changed
Merged

fix(test): Update schema for broken ConnImplBenchmark test#3574
PhongChuong merged 2 commits into
googleapis:mainfrom
o-shevchenko:benchmark

Conversation

o-shevchenko commented Nov 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm trying to use the executeSelect API and faced extremely slow reading.
I tried to use ConnImplBenchmark but noticed that the Shema was changed, and the test didn't work.

bigquery-public-data.new_york_taxi_trips.tlc_yellow_trips_2017

Summary of Changes
Added Fields: airport_fee, data_file_year, data_file_month.
Removed Fields: dropoff_longitude, dropoff_latitude, pickup_longitude, pickup_latitude.

After fixing the test I can confirm that we have similar speed results for our use cases.
Reading 100_000 rows takes ~15-20 seconds, which is extremely slow.

 Running
ROW 100000 Time: 14978 ms
ROW 200000 Time: 16409 ms
ROW 300000 Time: 16966 ms
ROW 400000 Time: 15963 ms
ROW 500000 Time: 17480 ms

I'm not sure if there was any performance degradation recently since I can't find any expected numbers. It's hard to read this benchmark: https://cloud.google.com/blog/topics/developers-practitioners/introducing-executeselect-client-library-method-and-how-use-it/
According to this image, reading of 1_000_000 rows should take ~1sec

That's what I've got on my machine:

Benchmark                                            (rowLimit)  Mode  Cnt       Score       Error  Units
ConnImplBenchmark.iterateRecordsUsingReadAPI             500000  avgt    3   76549.893 ± 14496.839  ms/op
ConnImplBenchmark.iterateRecordsUsingReadAPI            1000000  avgt    3  154957.127 ± 25916.110  ms/op
ConnImplBenchmark.iterateRecordsWithBigQuery_Query       500000  avgt    3   82508.807 ± 17930.275  ms/op
ConnImplBenchmark.iterateRecordsWithBigQuery_Query      1000000  avgt    3  165717.219 ± 86960.648  ms/op
ConnImplBenchmark.iterateRecordsWithoutUsingReadAPI      500000  avgt    3   84504.175 ± 36823.590  ms/op
ConnImplBenchmark.iterateRecordsWithoutUsingReadAPI     1000000  avgt    3  165142.367 ± 99899.991  ms/op

I've opened an issue: googleapis/java-bigquerystorage#2764

o-shevchenko requested review from a team and alvarowolfx November 14, 2024 18:27
product-auto-label Bot added the size: m Pull request size is medium. label Nov 14, 2024

google-cla Bot commented Nov 14, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

product-auto-label Bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Nov 14, 2024
o-shevchenko mentioned this pull request Nov 14, 2024
Closed
o-shevchenko changed the title Fix ConnImplBenchmark test fix(test): Update schema for broken ConnImplBenchmark test Nov 15, 2024

o-shevchenko commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

@alvarowolfx Could you please help with the review and performance evaluation?
Thanks!

o-shevchenko commented Nov 27, 2024

Copy link
Copy Markdown
Contributor Author

@alvarowolfx, did you have a chance to look into it?

alvarowolfx commented Nov 27, 2024

Copy link
Copy Markdown

@PhongChuong can you take a look on this one ?

PhongChuong approved these changes Dec 2, 2024
View reviewed changes

PhongChuong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the fix.
Lets discuss the slow read results in further in #2764.

PhongChuong commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

/gcbrun

o-shevchenko commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the fix. Lets discuss the slow read results in further in #2764.

Thanks for the reply. You probably mean googleapis/java-bigquerystorage#2764

PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 3, 2024
yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 3, 2024
PhongChuong merged commit 8cf4387 into googleapis:main Dec 3, 2024
release-please Bot mentioned this pull request Dec 3, 2024
Merged
o-shevchenko deleted the benchmark branch December 10, 2024 13:34
This was referenced Dec 17, 2024
Closed
Closed
Closed
o-shevchenko mentioned this pull request Jan 7, 2025
Merged
release-please Bot mentioned this pull request Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

alvarowolfx Awaiting requested review from alvarowolfx
1 more reviewer
PhongChuong PhongChuong approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL