feat: update with latest from main - #4034
Conversation
Sorry, something went wrong.
… data types (#4010) * feat: Create DataFormatOptions in BigQuery * feat: Add Builder class for DataFormatOptions * fix: Update existing references of useInt64Timestamp to use DataFormatOption's variant * chore: Fix lint issues * chore: Address PR feedback * chore: Add tests for useInt64Timestamp behavior * chore: Address failing tests and GCA * chore: Remove unused fromPb method
* feat: Add timestamp_precision to Field * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * chore: Address GCA PR feedback * chore: Fix typo * chore: Remove default value * chore: Address PR feedback --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…e than nanosecond precision (#4017) * chore: Use custom timestamp validator for ISO8601 timestamps with more than nanosecond precision * chore: Rename helper method to validateTimestamp * chore: Address GCA comments * chore: Address last GCA comment * chore: Update to use assert helper method
* chore: Cleanup initialized resources * chore: Delete created dataset * chore: Use try-with to close stream
* chore: Cleanup initialized resources * chore: Use try-with to close stream * chore: Cleanup Intellij test warnings * chore: Allow for floating point inaccuracies * chore: Add otel delete operation
Co-authored-by: Blake Li <blakeli@google.com>
* chore: Cleanup initialized resources * chore: Use try-with to close stream * chore: Cleanup Intellij test warnings * chore: Allow for floating point inaccuracies * chore: Add otel delete operation * chore: Clean up rest of the IT test file * chore: Add GCA feedback
deps update from bigquerystorage was incorrectly marked as chore(deps). This would cause the upgrade not show up in the release notes and also not trigger release please. This is because the pattern /^com.google.cloud:google-cloud-bigquery is configured in renovate.json, which matches both bigquery and bigquerystorage. However, I believe the original intention is only for bigquery update in samples, not for bigquerystorage update. Fixing the pattern so that the String must ends with bigquery
Summary of ChangesHello @diegomarquezp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the BigQuery client library to introduce a dedicated DataFormatOptions class, improving the configuration and handling of data type output formats, especially for timestamps. It deprecates the previous useInt64Timestamps setting in BigQueryOptions in favor of the new, more comprehensive DataFormatOptions object. Additionally, the changes extend the Field class to allow explicit timestampPrecision for TIMESTAMP fields and update QueryParameterValue to support picosecond precision for TIMESTAMP query parameters. These updates aim to provide more granular control and consistency in data formatting across the library. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements, primarily by refactoring timestamp handling into a new DataFormatOptions class and adding support for higher precision timestamps. This enhances maintainability and functionality. The changes are well-structured, and backward compatibility for useInt64Timestamps is thoughtfully handled. Additionally, numerous tests have been refactored and improved, increasing code quality. I've found one critical issue in Field.java that could lead to a NullPointerException, which I've detailed in a specific comment.
Sorry, something went wrong.
| Preconditions.checkArgument( | ||
| timestampPrecision == 6L || timestampPrecision == 12L, | ||
| "Timestamp Precision must be 6 (microsecond) or 12 (picosecond)"); |
There was a problem hiding this comment.
The Preconditions.checkArgument will throw a NullPointerException if timestampPrecision is null, because of the unboxing to long. The check should be updated to handle null values gracefully, as Long is a nullable type. You could either check for null before the precondition or include it in the precondition itself.
| Preconditions.checkArgument( | |
| timestampPrecision == 6L || timestampPrecision == 12L, | |
| "Timestamp Precision must be 6 (microsecond) or 12 (picosecond)"); | |
| Preconditions.checkArgument( | |
| timestampPrecision == null || timestampPrecision == 6L || timestampPrecision == 12L, | |
| "Timestamp Precision must be 6 (microsecond) or 12 (picosecond)"); |
Sorry, something went wrong.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
No description provided.