FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add ability to write Range values with JSONStreamWriter by PhongChuong · Pull Request #2498 · googleapis/java-bigquerystorage · GitHub

This repository was archived by the owner on Feb 24, 2026. It is now read-only.
/ java-bigquerystorage Public archive

feat: add ability to write Range values with JSONStreamWriter - #2498

Merged
PhongChuong merged 20 commits into
mainfrom
rangeJSONStreamWriter
May 31, 2024
ConversationCommits (20)ChecksFiles changed
Merged

feat: add ability to write Range values with JSONStreamWriter#2498
PhongChuong merged 20 commits into
mainfrom
rangeJSONStreamWriter

Conversation

PhongChuong commented May 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2481 ☕️

PhongChuong requested review from a team and agrawal-siddharth May 10, 2024 21:15
product-auto-label Bot added size: l Pull request size is large. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels May 10, 2024

PhongChuong commented May 10, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

1 similar comment

PhongChuong commented May 10, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

PhongChuong requested a review from shollyman May 10, 2024 21:42
yirutang requested a review from GaoleMeng May 13, 2024 16:56
yirutang reviewed May 16, 2024
View reviewed changes

yirutang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! Some nits.

Comment thread ...uerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryStorageTest.java Outdated
ServerStream<ReadRowsResponse> stream = client.readRowsCallable().call(readRowsRequest);
for (ReadRowsResponse response : stream) {
Preconditions.checkState(response.hasArrowRecordBatch());
rowCount += response.getRowCount();

yirutang May 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

validate the value?

PhongChuong May 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added validation.

Comment thread ...uerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryStorageTest.java Outdated

JSONObject row3 = new JSONObject();
JSONObject rangeDate3 = new JSONObject();
rangeDate3.put("start", 18262);

yirutang May 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

test date as a string?

PhongChuong May 30, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated to use string values.

Comment thread ...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels May 30, 2024

PhongChuong commented May 30, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

PhongChuong commented May 31, 2024
View reviewed changes

PhongChuong left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@yirutang
Thanks for the review. I've updated the PR with the suggestions. PTAL.

Comment thread ...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
Comment thread ...uerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryStorageTest.java Outdated

JSONObject row3 = new JSONObject();
JSONObject rangeDate3 = new JSONObject();
rangeDate3.put("start", 18262);

PhongChuong May 30, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated to use string values.

Comment thread ...uerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryStorageTest.java Outdated
ServerStream<ReadRowsResponse> stream = client.readRowsCallable().call(readRowsRequest);
for (ReadRowsResponse response : stream) {
Preconditions.checkState(response.hasArrowRecordBatch());
rowCount += response.getRowCount();

PhongChuong May 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added validation.

PhongChuong commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

PhongChuong commented May 31, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

PhongChuong merged commit a5e62be into main May 31, 2024
PhongChuong deleted the rangeJSONStreamWriter branch May 31, 2024 20:06
release-please Bot mentioned this pull request May 31, 2024
Merged
release-please Bot mentioned this pull request Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

agrawal-siddharth Awaiting requested review from agrawal-siddharth
shollyman Awaiting requested review from shollyman
GaoleMeng Awaiting requested review from GaoleMeng
1 more reviewer
yirutang yirutang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for Range types

2 participants

Back | FazBrowse Home | New Git URL