| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Signed-off-by: Diogo Teles Sant'Anna <diogoteles@google.com>
|
@diogoteles08 , lgtm but can you take a look also. There might be other instances elsewhere where this might be useful. |
Sorry, something went wrong.
Sorry, something went wrong.
|
@PhongChuong we have this script in other hw repos. |
Sorry, something went wrong.
|
I did a similar change in google-cloud-java: googleapis/google-cloud-java#10881 |
Sorry, something went wrong.
Hi! I did realize this very same workflow was used in other repositories of this org. I grouped some and pointed them in this comment: googleapis/java-storage#2663 (comment) |
Sorry, something went wrong.
|
/gcbrun |
Sorry, something went wrong.
|
@diogoteles08 just testing a few commits to confirm if we can also inline an env var in the if statement in this yaml. |
Sorry, something went wrong.
|
/gcbrun |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Hi! I'm Diogo from Google's Open Source Security Team(GOSST) and I'm dropping by to suggest this small change that will enhance the security of your repository by preventing script injection attacks through your GitHub workflows.
In the piece of code I changed, you were directly using the value of a variable that comes from a user's input, so a malicious user could exploit that input and use it to run arbitrary code. By using an intermediate environment variable, the value of the expression is stored in memory, used as a variable and doesn't interact with the script generation process. This mitigates the script injection risks and also keeps your workflow running exactly as before.
You can find more information about this on this github documentation or in this gitguardian blogpost.
Cheers!