FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: BQTableSchemaToProtoDescriptor setting of FieldOption. by PhongChuong · Pull Request #2743 · googleapis/java-bigquerystorage · GitHub

This repository was archived by the owner on Feb 24, 2026. It is now read-only.
/ java-bigquerystorage Public archive

fix: BQTableSchemaToProtoDescriptor setting of FieldOption. - #2743

Merged
PhongChuong merged 1 commit into
mainfrom
b376018662
Oct 28, 2024
ConversationCommits (1)ChecksFiles changed
Merged

fix: BQTableSchemaToProtoDescriptor setting of FieldOption.#2743
PhongChuong merged 1 commit into
mainfrom
b376018662

Conversation

PhongChuong commented Oct 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is to unblock protocol buffer version updates.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

fix: BQTableSchemaToProtoDescriptor setting of FieldOption.
918b413 
This is to unblock protocol buffer version updates.
product-auto-label Bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Oct 28, 2024
PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 28, 2024
PhongChuong marked this pull request as ready for review October 28, 2024 17:33
lqiu96 approved these changes Oct 28, 2024
View reviewed changes

lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

PhongChuong commented Oct 28, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews.

PhongChuong merged commit fb57909 into main Oct 28, 2024
PhongChuong deleted the b376018662 branch October 28, 2024 18:06
release-please Bot mentioned this pull request Oct 28, 2024
Merged
release-please Bot mentioned this pull request Dec 15, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

agrawal-siddharth Awaiting requested review from agrawal-siddharth
whuffman36 Awaiting requested review from whuffman36
2 more reviewers
shollyman shollyman approved these changes
lqiu96 lqiu96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL