This repository was archived by the owner on Feb 24, 2026. It is now read-only.
fix: don't start a retry timer if connection was closed due to being … - #2942
Merged
agrawal-siddharth merged 1 commit intoApr 22, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
agrawal-siddharth
requested review from
yirutang
and removed request for
shollyman
April 19, 2025 01:41
agrawal-siddharth
force-pushed
the
idleclose
branch
from
f59583f to
0473be8
Compare
April 19, 2025 15:56
yirutang
approved these changes
Apr 22, 2025
Comment thread
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/ConnectionWorker.java
Outdated
agrawal-siddharth
force-pushed
the
idleclose
branch
from
0473be8 to
79ce7f5
Compare
April 22, 2025 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…idle
An idle connection will be closed by the server after 10 minutes of inactivity. At some later time, the client may wish to resume sending traffic. At this time, in case we receive another disconnect event from the server, we should not count the time that has elapsed from the earlier idle disconnect. Instead, the time should begin from the latest disconnect event.