FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(sample): Add sample for native image support in Bigtable by mpeddada1 · Pull Request #1165 · googleapis/java-bigtable · GitHub

This repository was archived by the owner on May 8, 2026. It is now read-only.
/ java-bigtable Public archive

docs(sample): Add sample for native image support in Bigtable - #1165

Merged
mpeddada1 merged 4 commits into
mainfrom
add-native-samples
Feb 14, 2022
ConversationCommits (4)ChecksFiles changed
Merged

docs(sample): Add sample for native image support in Bigtable#1165
mpeddada1 merged 4 commits into
mainfrom
add-native-samples

Conversation

mpeddada1 commented Feb 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR copies over the sample for native image support in Bigtable from the old native image support repo.

Some things to note:

  1. This PR slightly modifies the sample code to be more test-friendly.
  2. It also adds an integration test that can be run as a native image.

Calling mvn package -Pnative in the native-image-sample directory builds the native image for the application and calling mvn test -Pnative runs the test as a native image.

For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration

mpeddada1 requested review from a team February 8, 2022 22:52

generated-files-bot Bot commented Feb 8, 2022

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

snippet-bot Bot commented Feb 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

product-auto-label Bot added api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Feb 8, 2022
Neenu1995 requested a review from kolea2 February 8, 2022 22:54

mpeddada1 commented Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

The failing GraalVM test is due to no tests being run with the native profile in the emulator module. This is a known issue with the native-maven-plugin, which fails with the following message: Execution test-native of goal org.graalvm.buildtools:native-maven-plugin:0.9.9:test failed: Test configuration file wasn't found.

mpeddada1 commented Feb 14, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review @lesv!

mpeddada1 merged commit 143aaee into main Feb 14, 2022
mpeddada1 deleted the add-native-samples branch February 14, 2022 15:39
release-please Bot mentioned this pull request Feb 14, 2022
Merged
anguillanneuf mentioned this pull request Mar 4, 2022
Merged
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Mar 18, 2022
docs(sample): Add sample for native image support in Bigtable (google…
5ba21f8 
…apis#1165)

* docs(sample): add sample for native image support

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add setup instructions to readme

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

suztomo Awaiting requested review from suztomo
Neenu1995 Awaiting requested review from Neenu1995
meltsufin Awaiting requested review from meltsufin
kolea2 Awaiting requested review from kolea2
1 more reviewer
lesv lesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

eaball35

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL