This repository was archived by the owner on May 8, 2026. It is now read-only.
deps: update sdk-platform-java-config to 3.55.0-rc1 - #2738
Merged
blakeli0 merged 8 commits intoDec 17, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Looks like an interface change to non-null is causing errors. Error: /home/runner/work/java-bigtable/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/changestream/ReadChangeStreamMergingAcceptanceTest.java:[288,19] error: [ImpossibleNullComparison] This value cannot be null, and comparing it to null may be misleading.
Error: (see https://errorprone.info/bugpattern/ImpossibleNullComparison)
Error: Did you mean 'return !testCase.getResultsList().isEmpty() && !results.isEmpty() && results.get(results.size() - 1).getError();'?
Error: /home/runner/work/java-bigtable/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/changestream/ReadChangeStreamMergingAcceptanceTest.java:[295,16] error: [ImpossibleNullComparison] This value cannot be null, and comparing it to null may be misleading.
Error: (see https://errorprone.info/bugpattern/ImpossibleNullComparison)
Error: Did you mean 'if (!testCase.getResultsList().isEmpty()) {'?
Error: /home/runner/work/java-bigtable/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java:[145,19] error: [ImpossibleNullComparison] This value cannot be null, and comparing it to null may be misleading.
Error: (see https://errorprone.info/bugpattern/ImpossibleNullComparison)
Error: Did you mean 'return !rrt.getResultsList().isEmpty() && !results.isEmpty() && results.get(results.size() - 1).getError();'?
Error: /home/runner/work/java-bigtable/java-bigtable/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java:[152,16] error: [ImpossibleNullComparison] This value cannot be null, and comparing it to null may be misleading.
Error: (see https://errorprone.info/bugpattern/ImpossibleNullComparison)
Error: Did you mean 'if (!rrt.getResultsList().isEmpty()) {'?
I'll use the suggested code (but using results.isEmpty() instead). |
Sorry, something went wrong.
blakeli0
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.