FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: adding pom profile to generate docfx yml from javadoc by eaball35 · Pull Request #213 · googleapis/java-shared-config · GitHub

This repository was archived by the owner on Jul 14, 2026. It is now read-only.
/ java-shared-config Public archive

feat: adding pom profile to generate docfx yml from javadoc - #213

Merged
eaball35 merged 3 commits into
masterfrom
docfx
Jan 21, 2021
ConversationCommits (3)ChecksFiles changed
Merged

feat: adding pom profile to generate docfx yml from javadoc#213
eaball35 merged 3 commits into
masterfrom
docfx

Conversation

eaball35 commented Jan 21, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

eaball35 requested a review from a team January 21, 2021 01:09

generated-files-bot Bot commented Jan 21, 2021 •
edited
Loading

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/release/common.cfg

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
eaball35 requested a review from lesv January 21, 2021 01:09
eaball35 closed this Jan 21, 2021
eaball35 reopened this Jan 21, 2021
eaball35 changed the title Changing pom config to generate docfx yml Adding pom profile to generate docfx yml from javadoc Jan 21, 2021
eaball35 changed the title Adding pom profile to generate docfx yml from javadoc feat: adding pom profile to generate docfx yml from javadoc Jan 21, 2021
lesv approved these changes Jan 21, 2021
View reviewed changes

lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Consider the suggestion.

Comment thread .kokoro/release/common.cfg Outdated
}

# Downloads docfx doclet resource. This will be in ${KOKORO_GFILE_DIR}/docfx-doclet-1.0-SNAPSHOT-jar-with-dependencies-143274.jar
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/docfx/docfx-doclet-1.0-SNAPSHOT-jar-with-dependencies-143274.jar" No newline at end of file

lesv Jan 21, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You might not need to be this explicit here - presume we'll update the file from time to time, why change several places?

eaball35 merged commit 3527c47 into master Jan 21, 2021
eaball35 deleted the docfx branch January 21, 2021 21:04
eaball35 restored the docfx branch February 11, 2021 19:57
eaball35 deleted the docfx branch February 11, 2021 20:02
eaball35 restored the docfx branch February 11, 2021 23:05
This was referenced Jan 4, 2022
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
lesv lesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL