FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: introduce Maven configuration for GraalVM testing by dzou · Pull Request #314 · googleapis/java-shared-config · GitHub

This repository was archived by the owner on Jul 14, 2026. It is now read-only.
/ java-shared-config Public archive

feat: introduce Maven configuration for GraalVM testing - #314

Merged
dzou merged 3 commits into
googleapis:mainfrom
dzou:graalvm-testing
Oct 7, 2021
ConversationCommits (3)ChecksFiles changed
Merged

feat: introduce Maven configuration for GraalVM testing#314
dzou merged 3 commits into
googleapis:mainfrom
dzou:graalvm-testing

Conversation

dzou commented Sep 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR introduces Maven project and Kokoro configuration for GraalVM native image testing.

With guidance from @lesv and @Neenu1995, our plan is to introduce changes that will be no-op (these change should not affect existing projects) while allowing individual repositories to opt-in GraalVM testing.

Summary of the changes proposed:

  • pom.xml - Adds an additional Maven profile (named native) which contains the dependencies and plugins to run all unit and integration tests compiled with GraalVM with a single command (mvn test -Pnative -Penable-integration-tests). This should also be a transparent change for existing projects as the changes are only enabled with activation of the profile.

A demo of this performed on the Secret Manager repo: googleapis/java-secretmanager#583

cc/ @suztomo

dzou requested a review from a team September 16, 2021 22:16

generated-files-bot Bot commented Sep 16, 2021

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2021
dzou changed the title Introduce job configuration for GraalVM integration testing feat: introduce Maven configuration for GraalVM integration testing Sep 16, 2021
dzou mentioned this pull request Sep 16, 2021
Closed
dzou changed the title feat: introduce Maven configuration for GraalVM integration testing feat: introduce Maven configuration for GraalVM testing Sep 16, 2021
lesv approved these changes Sep 22, 2021
View reviewed changes

lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

approve w/ question

Comment thread pom.xml Outdated
Comment on lines +844 to +851
<repositories>
<repository>
<id>snapshots-repo</id>
<url>https://google.oss.sonatype.org/content/repositories/snapshots</url>
<releases><enabled>false</enabled></releases>
<snapshots><enabled>true</enabled></snapshots>
</repository>
</repositories>

lesv Sep 22, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

is this needed?

lesv Sep 22, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can't you just use the -Pallow-snapshots

dzou Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done, I removed this. We will no longer be using snapshots as we will try to eventually pursue putting configuration into java-core or one of the shared dependencies.

Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2021

Neenu1995 commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

Waiting to change the artifact name before merging.

dzou added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 7, 2021

dzou commented Oct 7, 2021

Copy link
Copy Markdown
Contributor Author

Waiting to change the artifact name before merging.

Artifact renamed to native-image-support and updated in this commit: 7926bd4

Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 7, 2021
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
dzou merged commit 28fbeb8 into googleapis:main Oct 7, 2021
dzou deleted the graalvm-testing branch October 7, 2021 21:10
This was referenced Jan 4, 2022
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
lesv lesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL