This repository was archived by the owner on Jul 14, 2026. It is now read-only.
fix: use surefire-junit47 provider for surefire/failsafe plugins - #81
Merged
codyoss merged 1 commit intoJan 3, 2020
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
codyoss
approved these changes
Jan 3, 2020
This was referenced Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spanner tests use the grouping feature of tests and require using the junit47 provider for running the tests.
If we leave the junit4 provider in the shared-config and specify the junit47 provider downstream in the spanner repo, then tests run twice - once for each provider. The junit4 provider will not skip tests annotated as integration tests while running unit tests and will fail.