feat: include PostgreSQL error code in exceptions - #4236
Conversation
Sorry, something went wrong.
PostgreSQL error codes are now included in SpannerException when available. The PostgreSQL error code is only filled with a non-null value if the database is a Spanner PostgreSQL-dialect database, and the error is one that has a corresponding error code in PostgreSQL. See https://www.postgresql.org/docs/current/errcodes-appendix.html for a full list of all PostgreSQL error codes.
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the error reporting capabilities of the Spanner client library. By embedding PostgreSQL SQLSTATE error codes directly into SpannerException objects, it provides developers with more precise and actionable diagnostic information, especially when working with Spanner instances configured for PostgreSQL dialect. This change aims to streamline the debugging process and improve the overall developer experience by offering clearer insights into the root cause of database errors. Highlights
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here. Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
This pull request adds support for including PostgreSQL error codes in SpannerException and refactors exception creation to use a new asSpannerException method. The changes are generally good, but there's a systematic issue with how asSpannerException is called. In many places, it's called with an argument that might already be a SpannerException. Based on existing code patterns in SpannerApiFutures, it appears asSpannerException is not idempotent, which means these calls will re-wrap exceptions. This is undesirable as it can obscure the original stack trace. I've added several comments to address this by adding checks to handle existing SpannerException instances directly.
Sorry, something went wrong.
This reverts commit 5874f8b.
PostgreSQL error codes are now included in SpannerException when available.
The PostgreSQL error code is only filled with a non-null value if the database is a Spanner PostgreSQL-dialect database, and the error is one that has a corresponding error code in PostgreSQL.
See https://www.postgresql.org/docs/current/errcodes-appendix.html for a full list of all PostgreSQL error codes.