FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Refactor Custom Dual Region sample to work with API changes by sydney-munro · Pull Request #1516 · googleapis/java-storage · GitHub

/ java-storage Public

docs: Refactor Custom Dual Region sample to work with API changes - #1516

Merged
sydney-munro merged 3 commits into
mainfrom
custom-dual-sample
Jul 20, 2022
ConversationCommits (3)ChecksFiles changed
Merged

docs: Refactor Custom Dual Region sample to work with API changes#1516
sydney-munro merged 3 commits into
mainfrom
custom-dual-sample

Conversation

sydney-munro commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1429 ☕️

If you write sample code, please follow the samples format.

product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Jul 18, 2022
sydney-munro changed the title Custom dual sample docs: Custom dual sample Jul 18, 2022
sydney-munro changed the title docs: Custom dual sample docs: Refactor Custom Dual Region sample to work with API changes Jul 18, 2022
sydney-munro added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 18, 2022
sydney-munro removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 18, 2022
sydney-munro merged commit a60cace into main Jul 20, 2022
sydney-munro deleted the custom-dual-sample branch July 20, 2022 16:45
release-please Bot mentioned this pull request Jul 20, 2022
Merged
release-please Bot mentioned this pull request Aug 10, 2022
Closed
sydney-munro added a commit that referenced this pull request Oct 12, 2022
docs: Refactor Custom Dual Region sample to work with API changes (#1516
bcd8da4 
)

* docs: Refactor Custom Dual Region sample to work with API changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BenWhitehead BenWhitehead approved these changes
JesseLovelace Awaiting requested review from JesseLovelace
+3 more reviewers
lesv lesv approved these changes
frankyn frankyn approved these changes
danielbankhead danielbankhead approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

lesv

Labels

api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor(samples): Dual-Region Sample for Updated API

5 participants

Back | FazBrowse Home | New Git URL