docs: Fix broken links in readme - #1520
Merged
JesseLovelace merged 9 commits intoAug 10, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
#1511 Also calls out some outdated links in javadocs, can you check on those too? |
Sorry, something went wrong.
frankyn
suggested changes
Aug 8, 2022
Comment thread
README.md
| running on Compute Engine or from your own desktop. To run the example on App Engine, simply move | ||
| the code from the main method to your application's servlet class and change the print statements to | ||
| display on your webpage. | ||
| See [ListObjects.java](https://github.com/googleapis/java-storage/blob/main/samples/snippets/src/main/java/com/example/storage/object/ListObjects.java) for a complete example. |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Was this the regenerated changes? Not sure if they will be clobbered once merged again.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes, these are the result of owlbot updates after i edited the yaml file, so these changes are safe from clobbering
Sorry, something went wrong.
frankyn
approved these changes
Aug 9, 2022
BenWhitehead
approved these changes
Aug 10, 2022
This was referenced Aug 10, 2022
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
🤖 I have created a release *beep* *boop* --- ## [2.12.0](v2.11.3...v2.12.0) (2022-09-15) ### Features * Add toString method for CustomPlacementConfig ([#1602](#1602)) ([51aca10](51aca10)) ### Documentation * Add batch sample ([#1559](#1559)) ([583bf73](583bf73)) * Document thread safety of library ([#1566](#1566)) ([c740899](c740899)) * Fix broken links in readme ([#1520](#1520)) ([840b08a](840b08a)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1611](#1611)) ([8a48aea](8a48aea)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1620](#1620)) ([20e6378](20e6378)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1511
#1399