FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: update Grpc Retry Conformance after new additions to testbench by BenWhitehead · Pull Request #2309 · googleapis/java-storage · GitHub

/ java-storage Public

fix: update Grpc Retry Conformance after new additions to testbench - #2309

Merged
BenWhitehead merged 1 commit into
mainfrom
enable-grpc-retry-conformance-tests
Apr 17, 2024
ConversationCommits (1)ChecksFiles changed
Merged

fix: update Grpc Retry Conformance after new additions to testbench#2309
BenWhitehead merged 1 commit into
mainfrom
enable-grpc-retry-conformance-tests

Conversation

BenWhitehead commented Nov 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Grpc DeleteBucket idempotent inline with existing http
  • Grpc DeleteHmacKey idempotent inline with existing http
  • GrpcStorageImpl#create(BlobInfo, InputStream) changed from resumable upload to single-shot upload inline with http
  • GrpcStorageImpl#delete(String) update error handling only 404 translates to false inline with http
  • GrpcStorageImpl#writer(BlobInfo) await start resumable write for error reporting inline with http
  • Remove ITGrpcStorageImplUploadRetryTest now that we have grpc retry conformance tests which are more comprehensive

grpc setIamPolicy tests are currently disabled and will be enabled in a follow-up PR

BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Nov 17, 2023
BenWhitehead requested a review from a team November 17, 2023 19:36
product-auto-label Bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Nov 17, 2023

frankyn commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

oh no, there's a out of memory issue happening;

sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2023
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2023
sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2024
BenWhitehead force-pushed the enable-grpc-retry-conformance-tests branch from 1606b11 to 31936ef Compare April 17, 2024 21:18
product-auto-label Bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Apr 17, 2024
BenWhitehead changed the title test: enable gRPC retry conformance tests fix: update Grpc Retry Conformance after new additions to testbench Apr 17, 2024
BenWhitehead force-pushed the enable-grpc-retry-conformance-tests branch from 31936ef to 03e6c1a Compare April 17, 2024 21:26
BenWhitehead requested a review from frankyn April 17, 2024 21:28
BenWhitehead force-pushed the enable-grpc-retry-conformance-tests branch from 03e6c1a to 0612172 Compare April 17, 2024 22:14
product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 17, 2024
BenWhitehead merged commit 09043c5 into main Apr 17, 2024
BenWhitehead deleted the enable-grpc-retry-conformance-tests branch April 17, 2024 22:48
release-please Bot mentioned this pull request Apr 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
frankyn frankyn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL