feat: Adds Universe Domain support - #2362
Merged
JesseLovelace merged 7 commits intoJan 31, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
frankyn
reviewed
Jan 19, 2024
frankyn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, just comment on how to track when the code blocks and be remove / updated.
Sorry, something went wrong.
| public ServiceRpc create(StorageOptions options) { | ||
| if (options instanceof HttpStorageOptions) { | ||
| HttpStorageOptions httpStorageOptions = (HttpStorageOptions) options; | ||
| // todo: In the future, this step will be done automatically, and the getResolvedApiaryHost |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Is there a tracking bug to know when this will be addressed?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Added!
Sorry, something went wrong.
frankyn
approved these changes
Jan 31, 2024
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
🤖 I have created a release *beep* *boop* --- ## [2.33.0](https://togithub.com/googleapis/java-storage/compare/v2.32.1...v2.33.0) (2024-02-07) ### Features * Adds TPC support ([#2362](https://togithub.com/googleapis/java-storage/issues/2362)) ([8b636db](https://togithub.com/googleapis/java-storage/commit/8b636dbe8a16b9b81afbb51b8d0032bcbdbef635)) ### Bug Fixes * Temporarily restoring storage_grpc_service_config.json to fix broken test ([#2365](https://togithub.com/googleapis/java-storage/issues/2365)) ([50b6610](https://togithub.com/googleapis/java-storage/commit/50b6610de94d44815d80381649e7d3a86c38f894)) ### Dependencies * Update dependency com.google.apis:google-api-services-storage to v1-rev20240202-2.0.0 ([#2393](https://togithub.com/googleapis/java-storage/issues/2393)) ([3391e1d](https://togithub.com/googleapis/java-storage/commit/3391e1d3d925604fe57a69c40c823e863ce7593e)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.24.0 ([#2389](https://togithub.com/googleapis/java-storage/issues/2389)) ([9e4e00d](https://togithub.com/googleapis/java-storage/commit/9e4e00db40e8235b513f7f798674aba31631ddf4)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.0 ([#2390](https://togithub.com/googleapis/java-storage/issues/2390)) ([59ac502](https://togithub.com/googleapis/java-storage/commit/59ac502ee4c063ff46aa9dd0409df2e6fda7bc99)) * Update dependency org.junit.vintage:junit-vintage-engine to v5.10.2 ([#2394](https://togithub.com/googleapis/java-storage/issues/2394)) ([8dbd4bf](https://togithub.com/googleapis/java-storage/commit/8dbd4bfb4f76634f97b2e9cd3487128f4c98f58a)) * Update junit-platform.version to v5.10.2 ([#2395](https://togithub.com/googleapis/java-storage/issues/2395)) ([0c5aef3](https://togithub.com/googleapis/java-storage/commit/0c5aef34682ee56786f2006156f4cd645c22d8a8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an intercept when UniverseDomain is set in StorageOptions, which overrides the host in StorageOptions. It also changes signed URLs to respect custom hosts, including a specified universe domain.
There are no tests for this because Kokoro is not able to access any universes yet. I tested all these changes locally, and they're working against the staging universe.