feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig - #2434
Merged
sydney-munro merged 24 commits intoMar 15, 2024
Merged
feat: Add Custom Part Metadata Decorator to ParallelCompositeUploadConfig#2434sydney-munro merged 24 commits into
sydney-munro merged 24 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
sydney-munro
force-pushed
the
custom-metadata
branch
from
f244939 to
621d3a2
Compare
March 6, 2024 22:01
BenWhitehead
requested changes
Mar 11, 2024
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
sydney-munro
marked this pull request as ready for review
March 14, 2024 18:10
frankyn
reviewed
Mar 14, 2024
frankyn
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, @BenWhitehead i think is more involved at this point so leaving him to approve.
Sorry, something went wrong.
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
BenWhitehead
requested changes
Mar 14, 2024
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...rc/test/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfigTest.java
Outdated
Comment thread
...rc/test/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfigTest.java
Comment thread
...e/src/test/java/com/google/cloud/storage/ParallelCompositeUploadWritableByteChannelTest.java
sydney-munro
force-pushed
the
custom-metadata
branch
from
4d0e172 to
06b5c87
Compare
March 14, 2024 22:34
sydney-munro
force-pushed
the
custom-metadata
branch
3 times, most recently
from
1b963aa to
9bdf885
Compare
March 15, 2024 16:22
sydney-munro
force-pushed
the
custom-metadata
branch
from
2bc7c0a to
3236072
Compare
March 15, 2024 16:48
BenWhitehead
requested changes
Mar 15, 2024
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
Comment thread
...ge/src/main/java/com/google/cloud/storage/ParallelCompositeUploadBlobWriteSessionConfig.java
Outdated
…at we use to run a PCU
…rallelCompositeUploadBlobWriteSessionConfig.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
sydney-munro
force-pushed
the
custom-metadata
branch
from
484fc7d to
4861c85
Compare
March 15, 2024 18:17
BenWhitehead
approved these changes
Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.