FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: ensure all BlobWriteSession types conform to the semantics specified in BlobWriteSession by BenWhitehead · Pull Request #2482 · googleapis/java-storage · GitHub

fix: ensure all BlobWriteSession types conform to the semantics specified in BlobWriteSession - #2482

Merged
BenWhitehead merged 1 commit into
mainfrom
bws-semantic-test
Apr 11, 2024
Merged

fix: ensure all BlobWriteSession types conform to the semantics specified in BlobWriteSession#2482
BenWhitehead merged 1 commit into
mainfrom
bws-semantic-test

Conversation

Copy link
Copy Markdown
Collaborator
  • Improve error handling to cover more cases where errors should be converted to StorageException
  • Enforce BlobWriteSession#open only being able to be called once, subsequent calls will error
  • Make JsonResumableSessionPutTask more graceful when attempting to determine object size (testbench can omit .size from its response when the value is 0, possibly due to protobuf to json conversion where protobuf won't explicitly include a 0 value.)
  • Update com.google.cloud.storage.StorageException#coalesce to look for ApiException in causes the same way it does for BaseServiceException
  • Add com.google.cloud.storage.StorageOptions.Builder#setBlobWriteSessionConfig now that both Http and Grpc support these, having it on the base class is convenient
  • Add new integration test ITBlobWriteSessionCommonSemanticsTest which forces certain failure modes and ensures expected handling in accordance with the semantics outlined in BlobWriteSession

BenWhitehead added the owlbot:ignore instruct owl-bot to ignore a PR label Apr 1, 2024
BenWhitehead requested review from a team April 1, 2024 19:29
product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Apr 1, 2024
…fied in BlobWriteSession

* Improve error handling to cover more cases where errors should be converted to StorageException
* Enforce BlobWriteSession#open only being able to be called once, subsequent calls will error
* Make JsonResumableSessionPutTask more graceful when attempting to determine object size (testbench can omit `.size` from its response when the value is 0, possibly due to protobuf to json conversion where protobuf won't explicitly include a 0 value.)
* Update com.google.cloud.storage.StorageException#coalesce to look for ApiException in causes the same way it does for BaseServiceException
* Add com.google.cloud.storage.StorageOptions.Builder#setBlobWriteSessionConfig now that both Http and Grpc support these, having it on the base class is convenient
* Add new integration test ITBlobWriteSessionCommonSemanticsTest which forces certain failure modes and ensures expected handling in accordance with the semantics outlined in BlobWriteSession
BenWhitehead merged commit d47afcf into main Apr 11, 2024
BenWhitehead deleted the bws-semantic-test branch April 11, 2024 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL