fix: update GapicUnbufferedChunkedResumableWritableByteChannel to be tolerant of non-quantum aligned writes - #2537
Merged
BenWhitehead merged 1 commit intoMay 21, 2024
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…tolerant of non-quantum writes Update GapicUnbufferedChunkedResumableWritableByteChannel to only accept bytes at the 256KiB boundary when `#write(ByteBuffer[], int, int)` is called. Calls to writeAndClose(ByteBuffer[], int, int) will consume all bytes.
BenWhitehead
force-pushed
the
dangling-bytes-grpc
branch
from
ffeed31 to
e467886
Compare
May 9, 2024 17:37
sydney-munro
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update GapicUnbufferedChunkedResumableWritableByteChannel to only accept bytes at the 256KiB boundary when write(ByteBuffer[], int, int) is called.
Calls to writeAndClose(ByteBuffer[], int, int) will consume all bytes.