FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Managed Folders samples by sydney-munro · Pull Request #2562 · googleapis/java-storage · GitHub

/ java-storage Public

docs: Managed Folders samples - #2562

Merged
sydney-munro merged 7 commits into
mainfrom
mf
Jun 4, 2024
ConversationCommits (7)ChecksFiles changed
Merged

docs: Managed Folders samples#2562
sydney-munro merged 7 commits into
mainfrom
mf

Conversation

sydney-munro commented May 23, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

snippet-bot Bot commented May 23, 2024 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels May 23, 2024
gcf-owl-bot Bot requested review from a team May 23, 2024 19:48
sydney-munro added the owlbot:ignore instruct owl-bot to ignore a PR label May 23, 2024
sydney-munro force-pushed the mf branch 3 times, most recently from dfa9739 to ecc2b5d Compare May 29, 2024 21:50
product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jun 3, 2024
linter
669d721 
update without managed folder name populated

lint

format bucketname

enable uniform bucket level access

moving config update

enabling uniform bucket level access

figure out why tests are failing

use format instead of

linter

fixing tests

finally fix test and add in other tests

linter

adding copyrights to tests

removing unnecessary changed to downloadbytesrangetest
BenWhitehead requested changes Jun 4, 2024
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/CreateManagedFolder.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/DeleteManagedFolder.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/GetManagedFolder.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/ListManagedFolders.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/CreateManagedFolder.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/DeleteManagedFolder.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/GetManagedFolder.java Outdated
Comment thread samples/snippets/src/main/java/com/example/storage/managedfolders/ListManagedFolders.java Outdated
sydney-munro and others added 3 commits June 4, 2024 12:58
Update samples/snippets/src/main/java/com/example/storage/managedfold…
efe3156 
…ers/CreateManagedFolder.java

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Apply suggestions from code review
f48bc54 
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
pr comments
82b1ce7
BenWhitehead approved these changes Jun 4, 2024
View reviewed changes

BenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the fixes!

sydney-munro commented Jun 4, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

sydney-munro merged commit 5ffc1f2 into main Jun 4, 2024
sydney-munro deleted the mf branch June 4, 2024 23:09
release-please Bot mentioned this pull request Jun 4, 2024
Merged
sydney-munro mentioned this pull request Jun 6, 2024
Closed
This was referenced Jun 6, 2024
Closed
Closed
Closed
Closed
Closed
Closed
sofisl mentioned this pull request Jun 12, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BenWhitehead BenWhitehead approved these changes

Assignees

minherz

Labels

api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL