fix: update grpc finalize on close resumable uploads to validate ack'd object size - #2572
Merged
BenWhitehead merged 3 commits intoJun 13, 2024
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…d object size Follow up to #2527 Add ITGapicUnbufferedFinalizeOnCloseResumableWritableByteChannelTest with failure scenarios
…d object size Refactoring to clean up some request building lifecycle and variable scope
…d object size Tests are passing
sydney-munro
approved these changes
Jun 11, 2024
Comment thread
...ava/com/google/cloud/storage/GapicUnbufferedFinalizeOnCloseResumableWritableByteChannel.java
| null, | ||
| context, | ||
| null)); | ||
| } else if (last.hasResource() /* && finalizing*/) { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
left in commented out code
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Intentionally; The finalizing has to be true given the previous branches check, but I left it here for more easy readability
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2527 and #2514
Add ITGapicUnbufferedFinalizeOnCloseResumableWritableByteChannelTest with failure scenarios
Refactoring to clean up some request building lifecycle and variable scope
Update GapicUnbufferedFinalizeOnCloseResumableWritableByteChannel to validate ack'd object size