FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: Update DeleteObject Sample to be clearer on object versioning behavior by sydney-munro · Pull Request #2595 · googleapis/java-storage · GitHub

/ java-storage Public

docs: Update DeleteObject Sample to be clearer on object versioning behavior - #2595

Merged
sydney-munro merged 7 commits into
mainfrom
fix-delete-sample
Jun 26, 2024
ConversationCommits (7)ChecksFiles changed
Merged

docs: Update DeleteObject Sample to be clearer on object versioning behavior#2595
sydney-munro merged 7 commits into
mainfrom
fix-delete-sample

Conversation

sydney-munro commented Jun 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

product-auto-label Bot added the size: s Pull request size is small. label Jun 24, 2024
sydney-munro changed the title docs: Update DeleteObject Sample to be clearer on object versioning b… docs: Update DeleteObject Sample to be clearer on object versioning behavior Jun 24, 2024
product-auto-label Bot added the api: storage Issues related to the googleapis/java-storage API. label Jun 24, 2024
gcf-owl-bot Bot requested review from a team June 24, 2024 19:44

sydney-munro commented Jun 25, 2024

Copy link
Copy Markdown
Contributor Author

/gcbrun

BenWhitehead approved these changes Jun 25, 2024
View reviewed changes

BenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, getting another person to read over it would be good

JesseLovelace reviewed Jun 25, 2024
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/object/DeleteObject.java
Comment thread samples/snippets/src/main/java/com/example/storage/object/DeleteObject.java

System.out.println("Object " + objectName + " was deleted from " + bucketName);
BlobId idWithGeneration = blob.getBlobId();
// Deletes the blob specified by its id. When the generation is present and non-null it will be

JesseLovelace Jun 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think "when the generation is present" is a little vague, maybe we should specify as "When the generation is present in the BlobId object"?

sydney-munro Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

rephrased the comments. let me know if that is clearer.

JesseLovelace approved these changes Jun 26, 2024
View reviewed changes
Comment thread samples/snippets/src/main/java/com/example/storage/object/DeleteObject.java
storage.delete(bucketName, objectName, precondition);

System.out.println("Object " + objectName + " was deleted from " + bucketName);
BlobId idWithGeneration = blob.getBlobId();

JesseLovelace Jun 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

maybe add a comment on this line like "// The BlobId object has the Generation specified"

sydney-munro Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

i think the variable name is clear on this, no?

sydney-munro merged commit 79b7cf0 into main Jun 26, 2024
sydney-munro deleted the fix-delete-sample branch June 26, 2024 18:42
release-please Bot mentioned this pull request Jun 26, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

BenWhitehead BenWhitehead approved these changes
+1 more reviewer
JesseLovelace JesseLovelace approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL