feat: enable grpc.lb.locality label for client-side metrics - #2659
Merged
frankyn merged 1 commit intoAug 8, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
frankyn
marked this pull request as ready for review
August 1, 2024 20:02
Copy link
Copy Markdown
Contributor
|
tests ? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Requires manually testing this in a small app; I'll work with @JesseLovelace when he's back. |
Sorry, something went wrong.
JesseLovelace
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling grpc.lb.locality label
https://github.com/grpc/proposal/blob/master/A78-grpc-metrics-wrr-pf-xds.md#weighted-round-robin-lb-policy