fix: close pending zero-copy responses when Storage#close is called - #2696
Merged
BenWhitehead merged 1 commit intoSep 10, 2024
Merged
fix: close pending zero-copy responses when Storage#close is called#2696BenWhitehead merged 1 commit into
BenWhitehead merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Update gRPC based Storage instances to close out in progress reads when zero-copy is used and Storage#close() is called.
sydney-munro
approved these changes
Sep 9, 2024
Copy link
Copy Markdown
Collaborator
Author
|
integration test failures being investigated in #2697 |
Sorry, something went wrong.
BenWhitehead
added a commit
that referenced
this pull request
Sep 10, 2024
BenWhitehead
added a commit
that referenced
this pull request
Sep 10, 2024
BenWhitehead
added a commit
that referenced
this pull request
Sep 10, 2024
BenWhitehead
added a commit
that referenced
this pull request
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update gRPC based Storage instances to close out in progress reads when zero-copy is used and Storage#close() is called.