fix: set default values for monitored resource - #2809
Merged
frankyn merged 2 commits intoNov 5, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
frankyn
marked this pull request as ready for review
November 5, 2024 22:13
sydney-munro
approved these changes
Nov 5, 2024
sydney-munro
reviewed
Nov 5, 2024
Comment thread
...le-cloud-storage/src/main/java/com/google/cloud/storage/OpenTelemetryBootstrappingUtils.java
| .put("gcp.resource_type", "storage.googleapis.com/Client") | ||
| .put("project_id", projectIdToUse) | ||
| .put("instance_id", UUID.randomUUID().toString()) | ||
| .put("api", "grpc"); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nit: could we use something to detect grpc vs http even if this isn't set up for http yet? would make this reusable in the future.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
AFAIU, resource detector is platform dependent on https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/resourcedetectionprocessor/README.md#gcp-metadata
API type would need to be captured client side / added when introduced into the java storage client.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/377466694