feat: add new Storage#moveBlob method to atomically rename an object - #2882
Merged
BenWhitehead merged 2 commits intoJan 22, 2025
Merged
feat: add new Storage#moveBlob method to atomically rename an object#2882BenWhitehead merged 2 commits into
BenWhitehead merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
BenWhitehead
force-pushed
the
feat/move-blob
branch
from
edb9573 to
0700c72
Compare
January 14, 2025 21:30
| return new Builder(source, target, sourceOptions, targetOptions); | ||
| } | ||
|
|
||
| public static Builder newBuilder() { |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Do we maybe want to add something like MoveBlobRequest.of(BlobIdSource, BlobId target) for convenience?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
We could, but I sort of like having the builder methods that nudge people to at least think about preconditions. A move is only retryable if the target has a precondition set on it.
Sorry, something went wrong.
Comment thread
google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
Outdated
JesseLovelace
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.