docs: update storage_copy_file to include MegabytesCopiedPerChunk - #2910
Merged
BenWhitehead merged 1 commit intoFeb 5, 2025
Merged
docs: update storage_copy_file to include MegabytesCopiedPerChunk#2910BenWhitehead merged 1 commit into
BenWhitehead merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
tritone
approved these changes
Feb 5, 2025
tritone
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice changes!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GCS API that underpins Storage#copy(CopyRequest) is storage.objects.rewrite.
A rewrite is technically what we now refer to in Google Cloud API land as a Long Running Operation, meaning it's structured in such a way as to be able to take longer than would normally be acceptable for a single RPC.
In the case of performing the rewrite, GCS is "moving" the bytes over the google network and won't respond to the request at all until complete. If it takes GCS more than the client configured read timeout to actually "move" the bytes, the client interprets it as a read timeout and fails out.
Update the code snippet for copy to make it more robust to large objects.