feat(transfer-manager): add ParallelUploadConfig.Builder#setUploadBlobInfoFactory - #2936
Merged
BenWhitehead merged 1 commit intoFeb 18, 2025
Merged
feat(transfer-manager): add ParallelUploadConfig.Builder#setUploadBlobInfoFactory#2936BenWhitehead merged 1 commit into
BenWhitehead merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…bInfoFactory When uploading a file from the files system, there are scenarios when a job would need to customize the actual BlobInfo used to upload to GCS. Add the new UploadBlobInfoFactory which allows a user to produce their own BlobInfo instance given the bucketName and fileName. When producing the BlobInfo the application can also customize other metadata fields. A few convenience adapter methods are available in UploadBlobInfoFactory to simplify common operations. Fixes #2638
ddelgrosso1
approved these changes
Feb 18, 2025
ddelgrosso1
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. I'm assuming that test failure is expected as I noticed it failing last week?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Correct, ITKmsTest failure is being investigated separately |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When uploading a file from the files system, there are scenarios when a job would need to customize the actual BlobInfo used to upload to GCS.
Add the new UploadBlobInfoFactory which allows a user to produce their own BlobInfo instance given the bucketName and fileName. When producing the BlobInfo the application can also customize other metadata fields.
A few convenience adapter methods are available in UploadBlobInfoFactory to simplify common operations.
Fixes #2638