FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: update gRPC Bidi resumable upload to have more robust error message generation by BenWhitehead · Pull Request #2998 · googleapis/java-storage · GitHub

/ java-storage Public

fix: update gRPC Bidi resumable upload to have more robust error message generation - #2998

Merged
BenWhitehead merged 1 commit into
mainfrom
grpc/bidi/resumable-error-fix
Mar 18, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fix: update gRPC Bidi resumable upload to have more robust error message generation#2998
BenWhitehead merged 1 commit into
mainfrom
grpc/bidi/resumable-error-fix

Conversation

BenWhitehead commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator

onError can be called before a message is written to the stream, make sure we are accounting for the possibility that lastWrittenRequest can be null.

The fix prevents the following type of NPE from happening

Feb 18, 2025 10:39:15 PM io.grpc.internal.SerializingExecutor run
SEVERE: Exception while executing runnable io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed@5b549e5c
java.lang.NullPointerException
	at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:904)
	at com.google.common.collect.SingletonImmutableList.<init>(SingletonImmutableList.java:42)
	at com.google.common.collect.ImmutableList.of(ImmutableList.java:101)
	at com.google.cloud.storage.GapicBidiUnbufferedWritableByteChannel$BidiObserver.onError(GapicBidiUnbufferedWritableByteChannel.java:355)
	at com.google.api.gax.rpc.ApiStreamObserverAdapter.onErrorImpl(ApiStreamObserverAdapter.java:61)
	at com.google.api.gax.rpc.StateCheckingResponseObserver.onError(StateCheckingResponseObserver.java:84)
	at com.google.api.gax.tracing.TracedResponseObserver.onError(TracedResponseObserver.java:104)
	at com.google.api.gax.grpc.ExceptionResponseObserver.onErrorImpl(ExceptionResponseObserver.java:84)
	at com.google.api.gax.rpc.StateCheckingResponseObserver.onError(StateCheckingResponseObserver.java:84)
	at com.google.api.gax.grpc.GrpcDirectStreamController$ResponseObserverAdapter.onClose(GrpcDirectStreamController.java:148)
	at io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)
	at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)
	at io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)
	at com.google.api.gax.grpc.ChannelPool$ReleasingClientCall$1.onClose(ChannelPool.java:569)
	at io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)
	at io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)
	at io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)
	at com.google.cloud.storage.it.GrpcPlainRequestLoggingInterceptor$1$1.onClose(GrpcPlainRequestLoggingInterceptor.java:92)
	at io.grpc.internal.ClientCallImpl.closeObserver(ClientCallImpl.java:564)
	at io.grpc.internal.ClientCallImpl.access$100(ClientCallImpl.java:72)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInternal(ClientCallImpl.java:729)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1StreamClosed.runInContext(ClientCallImpl.java:710)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)

fix: update gRPC Bidi resumable upload to have more robust error mess…
669774c 
…age generation

onError can be called before a message is written to the stream, make sure we are accounting for the possibility that lastWrittenRequest can be null.
BenWhitehead requested a review from a team March 18, 2025 21:09
product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Mar 18, 2025
BenWhitehead merged commit 79b5d85 into main Mar 18, 2025
BenWhitehead deleted the grpc/bidi/resumable-error-fix branch March 18, 2025 21:38
release-please Bot mentioned this pull request Mar 18, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
andrewsg andrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL