deps: remove explicit version declarations for packages that are in shared-dependencies - #3014
Merged
JesseLovelace merged 2 commits intoMar 31, 2025
Merged
deps: remove explicit version declarations for packages that are in shared-dependencies #3014JesseLovelace merged 2 commits into
JesseLovelace merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
BenWhitehead
approved these changes
Mar 31, 2025
BenWhitehead
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
A couple additional cleanup items, but feel free to merge after those are taken care of.
Sorry, something went wrong.
Comment thread
pom.xml
Outdated
| @@ -81,33 +81,6 @@ | |||
| * io.opentelemetry.instrumentation:opentelemetry-resources | |||
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Can we remove this big comment too, it's no longer needed now that we're removing the semconv declaration.
Sorry, something went wrong.
Comment thread
pom.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gcp-resources still declares a version for now, but that will also be added to shared-deps and removed later