fix: update grpc client side metrics detection to be graceful when not running on gcp - #3097
Merged
BenWhitehead merged 1 commit intoMay 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…t running on gcp Refactor OpenTelemetryBootstrappingUtils to return a channel configurator function rather than mutating a passed in value. Add ChannelConfigurator interface to make testing easier and to simplify composition with any existing channel configurator function present in the InstantiatingGrpcChannelProvider.
cojenco
approved these changes
May 7, 2025
cojenco
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks Ben!
Sorry, something went wrong.
Comment thread
...le-cloud-storage/src/main/java/com/google/cloud/storage/OpenTelemetryBootstrappingUtils.java
Comment on lines
+104
to
+107
| if (projectId == null && detectedProjectId == null) { | ||
| log.warning( | ||
| "Unable to determine the Project ID in order to report metrics. No gRPC client metrics will be reported."); | ||
| return channelConfigurator != null ? channelConfigurator : ChannelConfigurator.identity(); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
qq: is this the case of not running on GCP?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
In a round about manner yes. The metrics reporting relies on application default credentials for initialization, and if the project can't be determined either as a passed in value from the Storage client, or resolved from the GCP resolved otel attributes there isn't any way to bootstrap.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor OpenTelemetryBootstrappingUtils to return a channel configurator function rather than mutating a passed in value.
Add ChannelConfigurator interface to make testing easier and to simplify composition with any existing channel configurator function present in the InstantiatingGrpcChannelProvider.