feat: expose BucketInfo.getProject as a BigInteger - #3119
Conversation
Sorry, something went wrong.
Expose publicly the project field which was previously internal only. This field represents the project number of the project the bucket belongs to. This field is still OUTPUT_ONLY, and as such does hot have a setter exposed for it. Fixes #3023
| "softDeletePolicy", | ||
| "hierarchicalNamespace", | ||
| "website"); | ||
| "projectNumber"); |
There was a problem hiding this comment.
website was defined twice, changing the second one to our new expected value.
Sorry, something went wrong.
| "items/softDeletePolicy", | ||
| "items/hierarchicalNamespace", | ||
| "items/website"); | ||
| "items/projectNumber"); |
There was a problem hiding this comment.
website was defined twice, changing the second one to our new expected value.
Sorry, something went wrong.
|
|
||
| @Override | ||
| Builder setProject(String project) { | ||
| Builder setProject(BigInteger project) { |
There was a problem hiding this comment.
Should we name it set/getProjectNumber to make it more clear?
Sorry, something went wrong.
There was a problem hiding this comment.
In the v2/storage.proto it's named project in the discovery doc it's named projectNumber. Rather annoying.
We first added this field internally when doing the gRPC effort and before projectNUmber was public. In this case, I'm simply exposing the getter for the field we already have plumbed around.
Sorry, something went wrong.
Expose publicly the project field which was previously internal only. This field represents the project number of the project the bucket belongs to.
This field is still OUTPUT_ONLY, and as such does hot have a setter exposed.
Fixes #3023