fix: update object context diff logic to be shallow rather than deep - #3287
Merged
BenWhitehead merged 6 commits intoSep 23, 2025
Merged
fix: update object context diff logic to be shallow rather than deep#3287BenWhitehead merged 6 commits into
BenWhitehead merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nidhiii-27
marked this pull request as ready for review
September 10, 2025 10:16
nidhiii-27
marked this pull request as draft
September 11, 2025 15:27
nidhiii-27
force-pushed
the
feat-object-contexts
branch
from
e6a5aae to
9916096
Compare
September 11, 2025 15:45
…oo handle ".value"
nidhiii-27
force-pushed
the
feat-object-contexts
branch
from
9916096 to
ce8d703
Compare
September 11, 2025 17:53
nidhiii-27
marked this pull request as ready for review
September 11, 2025 18:36
BenWhitehead
requested changes
Sep 22, 2025
BenWhitehead
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, deleting an object context key by setting its value to null would fail. This change corrects the diffMaps utility to ensure that null payloads are always treated as deletions.
The produced update mask is now contexts.custom.<key> instead of contexts.custom.<key>.value