fix: update DefaultRetryContext to trap and forward RejectedExceptionException to onFailure - #3327
Merged
BenWhitehead merged 1 commit intoOct 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…Exception to onFailure If the executor service provided to the DefaultRetryContext is shutdown and an onSuccess attempts to be scheduled a RejectedExceptionException will be thrown. Now, we catch and add it as a suppressed exception provided to recordError and immediately call onFailure, as we are no longer able to proceed with scheduling the retry.
bajajneha27
approved these changes
Oct 6, 2025
joe10832
approved these changes
Oct 7, 2025
joe10832
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the executor service provided to the DefaultRetryContext is shutdown and an onSuccess attempts to be scheduled a RejectedExceptionException will be thrown.
Now, we catch and add it as a suppressed exception provided to recordError and immediately call onFailure, as we are no longer able to proceed with scheduling the retry.